Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ListLoader component #6644

Merged
merged 5 commits into from
Mar 22, 2022
Merged

move ListLoader component #6644

merged 5 commits into from
Mar 22, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 22, 2022 •
edited
Loading

Description

Enhancement: Move ListLoader component

We've moved the ListLoader component into the web-pkg package and give it a more general name,
to ease the use in other packages.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

pascalwengerter
pascalwengerter approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, please squash-on-merge though 💩

changelog/unreleased/enhancement-move-list-loader-component
@@ -0,0 +1,6 @@
Enhancement: Move ListLoader component

We've moved the ListLoader component into the web-pkg package and give it a more general name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We've moved the ListLoader component into the web-pkg package and give it a more general name,
We've moved the ListLoader component into the web-pkg package and given it a more general name,

This is not worth another CI run but grammatically better

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 19912b9 into master Mar 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the outsource-component-list-loader branch March 22, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @pascalwengerter